-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI linting with clippy and rustfmt #5
Conversation
ff6e154
to
f877ed8
Compare
The second commit here is made automatically by the GitHub action. The first commit defines the CI workflow for the same. |
Greetings, I hope you are doing well. Generally I am all in favor of extending the CICD Pipeline here, although I do believe that the CICD Pipeline issuing commits is an antipattern. What do you think about modifying the Pipeline so that it will only check the formatting and fail if the code is not properly formatted? Fixing it would then be up to the user. Best Regards |
Absolutely. That can be done. |
Greetings, I have updated to only run the check and not issue automated commits. Best Regards. |
Hey, lets keep those, since I had that on my todo list anyways to let clippy do its clippy things. Best Regards |
It should be good to go now. You may have a look. |
Just a min. There's a little thing that needs fixing. |
Greetings, This should now turn red on any unfixed Clippy warnings. So one can be alerted to fix them. Best Regards. |
Took care of all uncovered Clippy warnings. 🙃 |
Merged, thanks for your contribution! Best Regards |
Did one quick fix on main, didn't catch that in the PR. Replaced main with master |
This will automate rust formatting and code quality fixes.